Skip to content

fix: fixes module resolution error #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2021
Merged

fix: fixes module resolution error #40

merged 4 commits into from
Feb 21, 2021

Conversation

@keturn
Copy link
Contributor

@keturn keturn commented Feb 21, 2021

For errors like this:

java.lang.IllegalStateException: Modules only available if resolution was successful
	at com.google.common.base.Preconditions.checkState(Preconditions.java:459)
	at org.terasology.module.ResolutionResult.getModules(ResolutionResult.java:47)

e.g. http://jenkins.terasology.io/teraorg/job/Terasology/job/Modules/view/Omega/job/T/job/Tasks/job/develop/16/testReport/junit/org.terasology.tasks.persistence/TaskGraphTypeHandlerTest/testDeserialize__/

Cervator
Cervator approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@Cervator Cervator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out fine via Gradle locally in an Omega workspace, actually has one more passing test in SimpleFarming than before, while Tasks got 100% success. Merging to see how Jenkins does - none of the few failures I saw locally seemed resolution related.

@Cervator Cervator merged commit 8880d01 into develop Feb 21, 2021
@Cervator Cervator deleted the fix/resolver branch February 21, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cervator Cervator Cervator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keturn @Cervator